bito-code-review[bot] commented on code in PR #39434: URL: https://github.com/apache/superset/pull/39434#discussion_r3740562156
########## superset-frontend/src/dashboard/components/PropertiesModal/sections/LabelColorMapping.tsx: ########## @@ -0,0 +1,339 @@ +/* eslint-disable @typescript-eslint/no-explicit-any */ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { useMemo, useState, useEffect, useRef } from 'react'; +import { t } from '@apache-superset/core/translation'; +import { styled } from '@apache-superset/core/theme'; + +const Container = styled.div` + ${({ theme }: any) => ` + margin-bottom: ${(theme?.gridUnit || 4) * 4}px; + padding: ${(theme?.gridUnit || 4) * 4}px; + background-color: ${theme?.colors?.grayscale?.light4}; + border-radius: ${theme?.borderRadius || 4}px; + `} +`; + +const HeaderRow = styled.div` + ${({ theme }: any) => ` + display: flex; + justify-content: space-between; + align-items: center; + margin-bottom: ${(theme?.gridUnit || 4) * 4}px; + `} +`; + +const Row = styled.div` + ${({ theme }: any) => ` + display: flex; + align-items: center; + margin-bottom: ${(theme?.gridUnit || 4) * 2}px; + gap: ${(theme?.gridUnit || 4) * 4}px; + `} +`; + +const InputGroup = styled.div` + display: flex; + align-items: center; + flex: 1; +`; Review Comment: <div> <div id="suggestion"> <div id="issue"><b>InputGroup lost spacing CSS</b></div> <div id="fix"> `InputGroup` (lines 51-55) lost its theme function and spacing CSS properties (`margin-bottom`, `gap`) that existed in the original code. These properties controlled vertical spacing between input groups and horizontal gap between input elements. Without them, the label input and color picker may have incorrect spacing or layout issues. </div> </div> <small><i>Code Review Run #890da4</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
