sadpandajoe commented on code in PR #42739:
URL: https://github.com/apache/superset/pull/42739#discussion_r3740976517
##########
superset/commands/streaming_export/base.py:
##########
@@ -223,13 +223,15 @@ def _execute_query_and_stream(
# Merge database to prevent DetachedInstanceError
merged_database = session.merge(database)
+ mutated_sql = merged_database.mutate_sql_based_on_config(sql)
Review Comment:
This common hook receives SQL that is already mutated by both callers
(`get_query_str()` mutates chart SQL, and SQL Lab persists the mutated
`executed_sql`), so the default configuration now runs non-idempotent mutators
twice; for charts with `MUTATE_AFTER_SPLIT=True`, both calls still skip the
hook instead. Could we make the caller contract carry raw/mutated state and the
correct split phase, with tests for both configuration modes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
