villebro commented on a change in pull request #8457: [fix] Improve csv upload
functionality
URL:
https://github.com/apache/incubator-superset/pull/8457#discussion_r342927379
##########
File path: superset/db_engine_specs/hive.py
##########
@@ -98,7 +98,7 @@ def fetch_data(cls, cursor, limit: int) -> List[Tuple]:
return []
@classmethod
- def create_table_from_csv(cls, form, table): # pylint:
disable=too-many-locals
+ def create_table_from_csv(cls, form): # pylint: disable=too-many-locals
Review comment:
@willbarrett I have tried to make sure the API remains compatible, i.e. both
`BaseEngineSpec` ja `HiveEngineSpec` now only take `form` as additional
parameters (I did forget to add the `None` return type to Hive, though). So
there shouldn't be any discrepancy between them. Or did I misunderstand
something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
