codeant-ai-for-open-source[bot] commented on code in PR #42952: URL: https://github.com/apache/superset/pull/42952#discussion_r3746116796
########## docs/docs/using-superset/exploring-data.mdx: ########## @@ -352,6 +352,13 @@ The **Custom** time range picker accepts natural language expressions alongside These expressions are evaluated at query time, so saved charts always display data relative to the current date. +### Downloading Drill to Detail and Drill By Results + +The **Drill to detail** and **Drill by** modals, available from a chart's context menu, show the row-level +data behind a chart (or behind a specific data point, when one is selected). Use the **Download** button in +the modal's toolbar to export the rows currently displayed in the table as CSV or Excel (XLSX), without +leaving the modal. Review Comment: **Suggestion:** The description is inaccurate for Drill to Detail: the download handler requests rows with `row_limit` set to the global limit and `row_offset` set to zero, rather than exporting the page currently visible in the paginated table. Clarify that the export may contain a broader result set than the current page. [api mismatch] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Drill-to-Detail exports may exceed the visible table page. - ⚠️ Users can receive unexpected row counts in downloaded files. - ⚠️ Export contents differ from the currently selected pagination page. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d7bbf1f454944a0ab5d1942f111dc4af&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d7bbf1f454944a0ab5d1942f111dc4af&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/docs/using-superset/exploring-data.mdx **Line:** 358:360 **Comment:** *Api Mismatch: The description is inaccurate for Drill to Detail: the download handler requests rows with `row_limit` set to the global limit and `row_offset` set to zero, rather than exporting the page currently visible in the paginated table. Clarify that the export may contain a broader result set than the current page. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42952&comment_hash=6036d3b431d63e2339451928f0a854f40cfb22907392677169467ad2ab1c2a49&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42952&comment_hash=6036d3b431d63e2339451928f0a854f40cfb22907392677169467ad2ab1c2a49&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
