bito-code-review[bot] commented on PR #42951: URL: https://github.com/apache/superset/pull/42951#issuecomment-5235096038
<!-- Bito Reply --> The flagged issue is correct. The documentation incorrectly states that all non-admins receive a 403 error, whereas the actual requirement is the `can_read` permission on the `Subject` resource, which can be granted to non-admin roles by administrators. To resolve this, update the documentation to clarify that `403` is the default behavior for callers lacking the `can_read` permission. Here is the corrected text for the relevant section: ```markdown Access is gated by the `can_read` permission on the `Subject` resource. By default, this is granted to Admins only, and callers without `can_read` receive a `403`. ``` There are no other comments on this PR to address. **docs/admin_docs/security/security.mdx** ``` Access is gated by the `can_read` permission on the `Subject` resource. By default, this is granted to Admins only, and callers without `can_read` receive a `403`. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
