chkang-idk2 opened a new pull request, #42957: URL: https://github.com/apache/superset/pull/42957
### SUMMARY Saving Dashboard Properties while the Certification accordion panel was never opened cleared `certified_by` / `certification_details`. The Properties modal uses an accordion `Collapse`, so Certification `FormItem`s are unregistered until that panel mounts. `form.getFieldsValue()` only returns registered fields, so those values became `undefined` and the PUT payload wrote `null`. `onFinish` now calls `form.getFieldsValue(true)` to read store values for unregistered fields (already set via `setFieldsValue` on load). Added a regression test that saves without opening Certification and asserts the certification fields are preserved. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://github.com/user-attachments/assets/fad7c3e4-8b71-4e1c-bfbf-bab8324d88be https://github.com/user-attachments/assets/c2d26ed6-e641-48df-a9c0-7a9c79135efb ### TESTING INSTRUCTIONS 1. Open a dashboard that already has Certified by / Certification details set. 2. Open **Dashboard properties**. 3. Do **not** expand the **Certification** section. 4. Click **Save**. 5. Re-open **Dashboard properties** → **Certification** and confirm the previous certification values are still present. Automated: ```bash cd superset-frontend npm test -- --testPathPatterns='dashboard/components/PropertiesModal/PropertiesModal.test' --testNamePattern='preserves certification fields' ``` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
