Antonio-RiveroMartnez commented on PR #42996: URL: https://github.com/apache/superset/pull/42996#issuecomment-5239510078
Thanks @rebenitez1802 — addressed the actionable points in `e109eec`. > `handle_error` never fires for query errors Scoped the PR and public docs to **connection errors and SQLAlchemy Core errors**. Added a real `get_raw_connection()` / `cursor.execute()` test showing raw DB-API query errors are intentionally outside the listener's scope. The PR title and description now say this plainly. > `sqlalchemy_exception=None` The listener now falls back to `context.original_exception`, with a dedicated test. > tests assert on total spy count The tests now select/assert the `handle_error` registration instead of relying on the total number of `event.listen` calls. > redundant `__closure__ is None` Removed. Validation: provenance tests **10 passed**, `core_test.py` **76 passed**, and staged-file pre-commit passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
