drivaspreset opened a new pull request, #43004: URL: https://github.com/apache/superset/pull/43004
### SUMMARY Adds Playwright E2E coverage for Global Async Queries (GAQ) on dashboards and SQL Lab. Eight dashboard-level tests cover the GAQ request/response lifecycle end to end: - Forced dashboard refresh going through the full 202 → poll → done cycle - Reloading an already-cached dashboard being served synchronously (never touching the async channel) - A broken chart surfacing a clean error under GAQ instead of hanging, and recovering once fixed - Rapidly switching a filter value without a superseded (stale) response clobbering the screen - A dashboard with many charts resolving every chart independently and correctly - Losing the async-token cookie bouncing chart refresh to `/login` even though the underlying session stays valid - Navigating away mid-load and back producing no console errors and re-rendering cleanly - A native filter's value dropdown populating through the same async pipeline as chart data A ninth test (`global-async-query-sqllab.spec.ts`) runs under the separate `chromium-sqllab` Playwright project and asserts that a simple `SELECT` in SQL Lab still runs synchronously with `GLOBAL_ASYNC_QUERIES` enabled, i.e. that the flag doesn't accidentally route SQL Lab traffic through the GAQ polling endpoint. `dashboard-test-helpers.ts` gains an optional `chartWidth` on `createDashboardWithCharts`, so tests can lay out more charts per row than the default single-row 12-column grid would otherwise allow (needed for the many-charts test). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A - test-only change, no UI behavior modified. ### TESTING INSTRUCTIONS Requires `GLOBAL_ASYNC_QUERIES` enabled, plus Redis and a running Celery worker (all tests except the cache-hit-reload case, which is served synchronously and only needs the feature flag). ```bash cd superset-frontend # dashboard GAQ suite npx playwright test tests/dashboard/global-async-query.spec.ts # SQL Lab smoke test (separate project) npx playwright test tests/sqllab/global-async-query-sqllab.spec.ts --project=chromium-sqllab ``` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: `GLOBAL_ASYNC_QUERIES` - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
