rusackas commented on code in PR #32487:
URL: https://github.com/apache/superset/pull/32487#discussion_r3752216955
##########
docker/entrypoints/run-server.sh:
##########
@@ -18,6 +18,9 @@
# under the License.
#
HYPHEN_SYMBOL='-'
+STATSD_HOST="${SERVER_STATSD_HOST:-localhost}"
+STATSD_PORT="${SERVER_STATSD_PORT:-8125}"
Review Comment:
There's no default host set here, `STATSD_ARGS` only gets populated if
`SERVER_STATSD_HOST` is explicitly configured. So nothing binds to any
interface unless the operator opts in.
##########
docker/entrypoints/run-server.sh:
##########
@@ -18,6 +18,9 @@
# under the License.
#
HYPHEN_SYMBOL='-'
+STATSD_HOST="${SERVER_STATSD_HOST:-localhost}"
Review Comment:
Same root cause, this was already addressed. `SERVER_STATSD_HOST` has no
default now, it's opt-in and `STATSD_ARGS` stays empty unless the operator sets
it explicitly, so there's no silent localhost-in-a-container failure mode
either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
