rusackas commented on PR #42629: URL: https://github.com/apache/superset/pull/42629#issuecomment-5243974652
@goingforstudying-ctrl One thing before this can go in. Codeant's thread on `auth.py`'s `nullcontext()` branch is still open and it's seemingly accurate: when `has_request_context()` is true, `_mcp_session_token` never gets set, so request-backed calls (the `WorkspaceContextMiddleware` path) still share the greenlet-scoped session, which is the exact race this PR fixes everywhere else. The other two codeant threads got addressed in f3bd3f7f (thanks!), but this one hasn't (yet!). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
