codecov-io edited a comment on issue #8519: [WIP][filter scope selector] part 
2: add algorithm to convert checked ids to scope object
URL: 
https://github.com/apache/incubator-superset/pull/8519#issuecomment-550492185
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8519?src=pr&el=h1)
 Report
   > Merging 
[#8519](https://codecov.io/gh/apache/incubator-superset/pull/8519?src=pr&el=desc)
 into 
[scope-selector-modal](https://codecov.io/gh/apache/incubator-superset/commit/69331853c1970705e1a6bf5255212b3aebb1a480?src=pr&el=desc)
 will **increase** coverage by `0.06%`.
   > The diff coverage is `93.02%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/8519/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8519?src=pr&el=tree)
   
   ```diff
   @@                   Coverage Diff                    @@
   ##           scope-selector-modal    #8519      +/-   ##
   ========================================================
   + Coverage                 66.75%   66.82%   +0.06%     
   ========================================================
     Files                       467      468       +1     
     Lines                     22848    22891      +43     
     Branches                   2467     2484      +17     
   ========================================================
   + Hits                      15253    15297      +44     
   + Misses                     7434     7433       -1     
     Partials                    161      161
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/8519?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/8519/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRGaWx0ZXJTY29wZUZyb21Ob2Rlc1RyZWUuanM=)
 | `93.02% <93.02%> (ø)` | |
   | 
[...assets/src/dashboard/util/getDashboardFilterKey.js](https://codecov.io/gh/apache/incubator-superset/pull/8519/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXREYXNoYm9hcmRGaWx0ZXJLZXkuanM=)
 | `100% <0%> (+66.66%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8519?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8519?src=pr&el=footer).
 Last update 
[6933185...70ea11e](https://codecov.io/gh/apache/incubator-superset/pull/8519?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to