rusackas commented on PR #42752: URL: https://github.com/apache/superset/pull/42752#issuecomment-5244888529
Looking again, there may be some follow-up work here. The regression test compiles with `literal_binds=True`, which renders values straight into SQL text and skips the bind-parameter path that actually caused the original truncation, so it wouldn't fail without this fix. Worth asserting against a normal compiled statement (no literal binds) or executing against a real engine instead. A follow-up here would be welcomed if you're up for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
