rusackas opened a new pull request, #43014: URL: https://github.com/apache/superset/pull/43014
Follow-up to #41205. ### SUMMARY That PR widened the `Routes` type in `superset-frontend/src/views/routes.tsx` from `ComponentType` to `ComponentType<any>`, which violates the project's no-`any` policy, and it left `RoutePaths.REGISTRATIONS` registered twice: once unconditionally in the base `routes` array and again gated behind `authRegistrationEnabled`. This PR restores the narrower `ComponentType` generic and removes the redundant unconditional entry so the registrations route is only registered when user self-registration is enabled. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A - no UI change. ### TESTING INSTRUCTIONS - Confirm `superset-frontend/src/views/routes.tsx` no longer has a duplicate `RoutePaths.REGISTRATIONS` entry. - With `AUTH_USER_REGISTRATION` disabled, `/registrations/` is no longer registered as a frontend route. - With `AUTH_USER_REGISTRATION` enabled, `/registrations/` still routes to `UserRegistrations` as before. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
