rusackas commented on issue #43021: URL: https://github.com/apache/superset/issues/43021#issuecomment-5246517023
Related prior work, for context: [SIP-216 / #41463](https://github.com/apache/superset/issues/41463) (closed as completed, implemented in #41184) fixed a related-but-different problem — it made totals/subtotals **mathematically correct** for whatever aggregation a metric already uses (e.g. an `AVG` metric now totals as a true average via DB-level `GROUPING SETS`, instead of naively summing already-aggregated per-row values). That correctness fix landed for the **Pivot Table** chart; the **Table chart's** totals row only picked up the narrower "retain post-processing so percent/contribution columns aren't dropped" piece (#37627/#34350), not the additive/non-additive-aware DB rollup. This issue is asking for something SIP-216 doesn't cover even where it *did* land: an **independently user-selectable** aggregation for the summary row (e.g. show per-row `SUM`, but total as `AVG`), rather than the summary row being locked to whatever aggregation the metric itself already specifies. Confirmed on master: `plugin-chart-table`/`plugin-chart-ag-grid-table`'s `buildQuery.ts` still just reruns the same metric definitions for the totals query, and neither has the `isAdditiveMetric`/rollup machinery that `plugin-chart-pivot-table` has. Picking this up — will open a PR shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
