GitHub user rusackas added a comment to the discussion: [Bug] `/api/v1/chart/warm_up_cache` generates different cache keys than runtime - Filter Order Mismatch
Confirmed this is real, verified both root causes myself against current `master` rather than just trusting the write-up (and the write-up holds up well, though I'd push back a little on the `dosu` bot's aside — it says the non-legacy warmup path "doesn't appear to inject dashboard filters at all," but that's wrong, it still does the `.extend()` append). This should've been an issue, not a discussion, so I filed one: #43024. Also found something useful for whoever picks up the fix: there's already a correct native-filter extractor wired into the real `/api/v1/chart/data` endpoint (`get_dashboard_filter_context`/`apply_dashboard_filter_context` in `superset/charts/data/dashboard_filter_context.py`). `ChartWarmUpCacheCommand` just isn't using it — reusing that instead of patching `get_dashboard_extra_filters` directly is probably the more correct fix than the one-line prepend you proposed. Opened a test-only PR pinning the native-filter part of this: #43025. Left the filter-order part (your Option A/B) as a follow-up once that's fixed, since both need to land for warming to actually work. GitHub link: https://github.com/apache/superset/discussions/42382#discussioncomment-17968485 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
