bito-code-review[bot] commented on code in PR #43027: URL: https://github.com/apache/superset/pull/43027#discussion_r3754015141
########## superset-frontend/packages/superset-ui-chart-controls/src/utils/index.ts: ########## @@ -22,6 +22,7 @@ export * from './selectOptions'; export * from './D3Formatting'; export * from './expandControlConfig'; export * from './getColorFormatters'; +export * from './getTotalsMetrics'; Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing unit tests for new utility</b></div> <div id="fix"> The `getTotalsMetrics` utility was introduced in commit 79cec2ef74 but has no unit tests. This function is used by plugin-chart-table and plugin-chart-ag-grid-table for production chart queries. BITO.md rule [11730] requires comprehensive unit tests for new tools — missing tests risk undetected regressions in the totals calculation logic. </div> </div> <small><i>Code Review Run #5a2352</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset-frontend/packages/superset-ui-chart-controls/src/utils/getTotalsMetrics.ts: ########## @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { isAdhocMetricSimple, QueryFormMetric } from '@superset-ui/core'; + +export type TotalsAggregate = 'SUM' | 'AVG'; + +/** + * Build the metrics for a chart's "Show summary" totals query, overriding + * each Simple (adhoc) metric's aggregate function with the user-chosen + * totals aggregate. The totals query has no GROUP BY, so the database + * evaluates each metric fresh over all rows -- swapping the aggregate here + * is a correct, independent computation, not a re-aggregation of + * already-aggregated per-row values. + * + * Custom-SQL metrics and saved (string) metrics pass through unchanged: + * there is no safe way to rewrite an arbitrary SQL expression's aggregate + * function without parsing it, so the totals row keeps their own native + * aggregate for those. + */ +export function getTotalsMetrics( + metrics: QueryFormMetric[], + aggregate: TotalsAggregate, +): QueryFormMetric[] { + return metrics.map(metric => + isAdhocMetricSimple(metric) ? { ...metric, aggregate } : metric, + ); +} Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing unit tests</b></div> <div id="fix"> This new utility function is used in production by plugin-chart-table and plugin-chart-ag-grid-table but lacks unit tests. Per BITO.md rule 11730, new tools must have tests covering success paths, error scenarios, and edge cases. Tests would verify the aggregate override logic for simple metrics and the passthrough behavior for saved/SQL metrics. </div> </div> <small><i>Code Review Run #5a2352</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
