sadpandajoe commented on code in PR #42994:
URL: https://github.com/apache/superset/pull/42994#discussion_r3754209749
##########
superset-frontend/src/pages/AlertReportList/index.tsx:
##########
@@ -190,23 +190,31 @@ function AlertList({
}
executingIdsRef.current.add(alertId);
+ const isReport = alert.type === 'Report';
executeReport(
alertId,
() => {
addSuccessToast(
- t('%(alertType)s "%(alertName)s" triggered successfully', {
- alertType: alert.type,
- alertName: alert.name,
- }),
+ isReport
+ ? t('Report "%(alertName)s" triggered successfully', {
Review Comment:
This changes the msgid, but the existing Japanese and Portuguese catalog
entries are still keyed by the old generic string, so these toasts now fall
back to English for those locales. Could we keep the translated msgid or update
the catalogs with the new keys?
##########
.claude/projects/js-to-ts/PROJECT.md:
##########
@@ -1,76 +1,31 @@
# JavaScript to TypeScript Migration Project
-Progressive migration of 219 JS/JSX files to TypeScript in Apache Superset
frontend.
+Migration of JS/JSX application files to TypeScript in Apache Superset
frontend.
## 📁 Project Documentation
- **[AGENT.md](./AGENT.md)** - Complete technical migration guide for agents
(includes type reference, patterns, validation)
- **[COORDINATOR.md](./COORDINATOR.md)** - Strategic workflow for coordinators
(file selection, task management, integration)
-## 🎯 Quick Start
+## 📊 Migration Status
-**For Agents:** Read [AGENT.md](./AGENT.md) for complete migration instructions
-**For Coordinators:** Read [COORDINATOR.md](./COORDINATOR.md) for workflow and
[AGENT.md](./AGENT.md) for supervision
+**Application Code Status**: Complete ✅ (`superset-frontend/src` and
`plugins/` have 0 `.js`/`.jsx` files).
-**Command:** `/js-to-ts <filename>` - See
[../../commands/js-to-ts.md](../../commands/js-to-ts.md)
-
-## 📊 Migration Progress
-
-**Scope**: 219 files total (112 JS + 107 JSX)
-- Production files: 139 (63%)
-- Test files: 80 (37%)
-
-**Strategy**: Leaf-first migration with dependency-aware coordination
-
-### Completed Migrations ✅
-
-1. **roundDecimal** -
`plugins/legacy-plugin-chart-map-box/src/utils/roundDecimal.js`
- - Migrated core + test files
- - Added proper TypeScript function signature with optional precision
parameter
- - All tests pass
-
-2. **timeGrainSqlaAnimationOverrides** -
`src/explore/controlPanels/timeGrainSqlaAnimationOverrides.js`
- - Migrated to TypeScript with ControlPanelState and Dataset types
- - Added TimeGrainOverrideState interface for return type
- - Used type guards for safe property access
-
-3. **DebouncedMessageQueue** - `src/utils/DebouncedMessageQueue.js`
- - Migrated to TypeScript with proper generics
- - Created DebouncedMessageQueueOptions interface
- - **CREATED test file** with 4 comprehensive test cases
- - Excellent class property typing with private/readonly modifiers
-
-**Files Migrated**: 3/219 (1.4%)
-**Tests Created**: 2 (roundDecimal had existing, DebouncedMessageQueue created)
-
-### Next Candidates (Leaf Nodes) 🎯
-
-**Identified leaf files with no JS/JSX dependencies:**
-- `src/utils/hostNamesConfig.js` - Domain configuration utility
-- `src/explore/controlPanels/Separator.js` - Control panel configuration
-- `src/middleware/loggerMiddleware.js` - Logging middleware
-
-**Migration Quality**: All completed migrations have:
-- ✅ Zero `any` types
-- ✅ Proper TypeScript compilation
-- ✅ ESLint validation passed
-- ✅ Test coverage (created where missing)
+Only 6 `.js` files remain across `superset-frontend/packages`, which consist
of generator scripts and test mock templates:
+- `superset-frontend/packages/generator-superset/jest.config.js`
+- `superset-frontend/packages/generator-superset/generators/app/index.js`
+-
`superset-frontend/packages/generator-superset/generators/plugin-chart/index.js`
+-
`superset-frontend/packages/generator-superset/generators/plugin-chart/templates/test/__mocks__/mockExportString.js`
+- `superset-frontend/packages/superset-ui-core/__mocks__/mockExportString.js`
+- `superset-frontend/packages/superset-ui-core/__mocks__/mockExportObject.js`
---
## 📈 Success Metrics
-**Per-File Gates**:
-- ✅ `npm run type` passes after each migration
-- ✅ Zero `any` types introduced
-- ✅ All imports properly typed
-- ✅ Types filed in correct hierarchy
-
-**Overall Progress**:
-- **Automatic Integration Rate**: 100% (3/3 migrations required no coordinator
fixes)
-- **Test Coverage**: Improved (1 new test file created)
-- **Type Safety**: Enhanced with proper interfaces and generics
+- **Application Code (`src/`, `plugins/`)**: 100% TypeScript
+- **Type Safety**: All application code components and utilities are typed in
TypeScript without `any` types.
Review Comment:
This says the application code has no `any` types, but
`superset-frontend/src/types/bootstrapTypes.ts` still has production `any`
annotations (for example `config?: any`). Could this be narrowed to the JS/JSX
migration status rather than claiming complete type safety?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
