bito-code-review[bot] commented on code in PR #43053:
URL: https://github.com/apache/superset/pull/43053#discussion_r3756453443
##########
superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridCell.test.tsx:
##########
@@ -210,3 +300,170 @@ test('should handle empty cell data gracefully', () => {
// Should still render but with empty title
expect(screen.getByText('SuperChart Mock')).toBeInTheDocument();
});
+
+test('renders chart eagerly when virtualization is disabled', () => {
+ renderWithTheme(<MatrixifyGridCell {...defaultProps} />);
+
+ expect(screen.getByText('SuperChart Mock')).toBeInTheDocument();
+ expect(
+ screen.queryByTestId('matrixify-cell-placeholder'),
Review Comment:
<!-- Bito Reply -->
If the project's testing setup globally maps `data-test` to the
`testIdAttribute` used by `screen.getByTestId`, then this suggestion is indeed
a false positive. You can safely ignore this comment, as the existing test
convention is consistent with the project's global configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
