greggailly commented on code in PR #42483:
URL: https://github.com/apache/superset/pull/42483#discussion_r3757283559
##########
superset-frontend/src/explore/components/DatasourcePanel/DatasourcePanelItem.tsx:
##########
@@ -188,10 +230,17 @@ const DatasourcePanelItem = ({
...style,
paddingLeft: theme.sizeUnit * 4 + indentation,
paddingRight: theme.sizeUnit * 4,
+ opacity: isRowInDraggedFolder ? 0.5 : undefined,
}}
>
{item.type === 'header' && (
- <SectionHeaderButton onClick={() => onToggleCollapse(folder.id)}>
+ <SectionHeaderButton
+ ref={setFolderDragRef}
+ onClick={() => onToggleCollapse(folder.id)}
+ style={{ cursor: folderDragItems.length ? 'grab' : undefined }}
+ {...folderDragAttributes}
+ {...folderDragListeners}
Review Comment:
Created a dedicated handle for this. Does have the "inconvenience" of
restricting the drag to the handle but make more sense to have a single action
when clicking/using default keyboard actions on the button.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
