GitHub user bmuraykhi added a comment to the discussion: Add number formats for network throughput (Mbps/Gbps)
Thanks for looking! Already done: #42437, which you merged today as 9d6832c927. It adds `NETWORK_THROUGHPUT` for bits/s columns and `NETWORK_THROUGHPUT_FROM_BYTES` for bytes/s ones. I made it a separate `createThroughputFormatter` rather than a flag on `createMemoryFormatter`, so the existing MEMORY_* formats stay untouched. Easy to combine them later if you want. Side note: I hit two small bugs in `createMemoryFormatter` while there. formatter(0.5) returns '500undefined', and 999999 shows 1000kB instead of 1MB. I have a fix ready if you want a PR. GitHub link: https://github.com/apache/superset/discussions/42436#discussioncomment-17976176 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
