rusackas commented on PR #42475: URL: https://github.com/apache/superset/pull/42475#issuecomment-5258652670
Thanks @SkinnyPigeon! Good call reusing `propertyComparator` instead of hand-rolling it, keeps this consistent with how sorting works everywhere else in the app. Test fixture change addresses the earlier concern about it not actually discriminating sorted vs unsorted output. LGTM, approving. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
