rusackas commented on PR #43004: URL: https://github.com/apache/superset/pull/43004#issuecomment-5259077821
Heya @drivaspreset, nice coverage here on GAQ. @sadpandajoe's review comments are still open though, mostly pointing at duplicated code that could reuse existing helpers (`apiPutChart`, `apiPostChart`, the combo box filter component, the button component) - worth folding those in, this file's big enough that the reuse would help. Codeant's race-condition threads look legit too: the `girl`/`boy` race assertion around line 583 doesn't actually confirm the fast request completed before checking for staleness, and the native-filter dropdown test around line 1172 arms its response listener before navigation, so it could pass without the click ever hitting GAQ. Worth tightening those up before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
