bito-code-review[bot] commented on PR #43081:
URL: https://github.com/apache/superset/pull/43081#issuecomment-5260595781
<!-- Bito Reply -->
The flagged issue is correct. The `GLOBAL_ASYNC_QUERIES` path in
`_run_async` currently lacks the `QueryObjectValidationError` handling that was
added to `_get_data_response`. To resolve this, you should wrap the
`command.execute(force_cached=True)` call in a try-except block that catches
`QueryObjectValidationError` and returns a 400 response, similar to the
implementation in `_get_data_response`.
**superset/charts/data/api.py**
```
try:
result = command.execute(force_cached=True)
except QueryObjectValidationError as exc:
return
self.response_400(message=sanitize_error_message(exc.message))
except ChartDataCacheLoadError:
# ... existing logic ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
