verdier commented on PR #43007: URL: https://github.com/apache/superset/pull/43007#issuecomment-5262858565
Will do. Once #42629 merges I will open the follow-up with the admission control: the middleware outside the logger, the pool-derived default and `MCP_MAX_CONCURRENT_TOOL_CALLS`, the reentrancy fix and its test, and the measurements rerun on #42629's isolation rather than mine so the table describes what actually landed. One thing from `70c258f` worth separating from the semaphore: the double middleware pass I described above is master's behaviour, not this branch's. Nothing in the chain holds a resource across a call today, so I plan to document it in the follow-up rather than file it. Happy to open an issue instead if you would rather have it tracked on its own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
