bito-code-review[bot] commented on code in PR #42941:
URL: https://github.com/apache/superset/pull/42941#discussion_r3770843537
##########
superset-frontend/plugins/plugin-chart-country-map/src/transformProps.ts:
##########
@@ -64,6 +67,7 @@ export default function transformProps(chartProps:
ChartProps) {
? { country_id: row[entityLabel], metric: row[metricLabel] }
: row,
);
+ const formatters = getColorFormatters(conditionalFormatting, data, theme);
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing test coverage for formatters</b></div>
<div id="fix">
The new `formatters` output is not verified in existing tests. Per BITO.md
rule [6262], tests should verify actual business logic — adding a mock for
`getColorFormatters` (pattern used in `BigNumberTotal/transformProps.test.ts`)
and asserting `formatters` appears in output would prevent regressions.
</div>
</div>
<small><i>Code Review Run #af12a7</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
