sha174n commented on PR #42328: URL: https://github.com/apache/superset/pull/42328#issuecomment-5281443421
Two things: 1. The merge migration aaed1198e21f looks like rebase cruft — master already merges those same two heads (4f145192b583 + c4a1b8e2d739) via d7cecc48bd55, so adding a second merge of the same pair reintroduces multiple Alembic heads. I think it can be dropped (and the "Includes DB Migration" box ticked if any real migration remains). 2. The description says "on existing example datasets; no new data files", but the diff adds two parquet files (quarterly_sales_delta, sales_territory_hierarchy) plus their dataset YAMLs that the Waterfall/Tree examples depend on — worth correcting the body. The thumbnail tool and example loading otherwise look solid: gated behind CAPTURE_THUMBNAILS so it never runs in CI, charts discovered via API rather than hardcoded IDs, and the UUID-keyed import path with auto-discovered parquets is idempotent on re-run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
