WhoamiI00 commented on issue #36840: URL: https://github.com/apache/superset/issues/36840#issuecomment-5281953768
Opened #43115 for this. Two notes from digging in, since this is still `validation:required`: The **UI freeze** doesn't reproduce on current master — the request path settles and renders an error alert instead of hanging, so whatever caused the hang looks to have been fixed since December. What does still reproduce is that a 200 without a `result` payload leaks an internal error into the pane: ``` Failed to load samples TypeError: Cannot read properties of undefined (reading 'data') ``` `getDatasourceSamples` returns `response.json.result`, so that case resolves to `undefined` and `SamplesPane` reads `response.data` straight off it. The PR reads through the response so it falls back to the "No samples were returned for this dataset" empty state the component already has — which matches the expected behaviour in this report. There's a regression test that fails on master with that exact TypeError. Worth noting the backend returning an empty 200 for `/datasource/samples` may still be worth a separate look; this only makes the frontend degrade cleanly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
