rusackas commented on PR #43027: URL: https://github.com/apache/superset/pull/43027#issuecomment-5283775342
@sha174n thanks for the review! Same tradeoff a bot flagged elsewhere on this PR, and I landed on the same answer: guarding it properly needs column-type info `getTotalsMetrics` doesn't have, just the metric shape. Docstring on `getTotalsMetrics` now spells out that all simple metrics get the override, so at least it's not a surprise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
