bito-code-review[bot] commented on code in PR #42995: URL: https://github.com/apache/superset/pull/42995#discussion_r3777793403
########## helm/superset/tests/pdb_test.yaml: ########## @@ -0,0 +1,87 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +suite: pod disruption budgets +templates: + - pdb.yaml + - pdb-worker.yaml + - pdb-beat.yaml + - pdb-flower.yaml + - pdb-ws.yaml + - pdb-mcp.yaml + +# The chart must not ship conflicting minAvailable/maxUnavailable defaults: enabling a +# PDB with `enabled: true` alone has to render, since Helm merges user values on top of +# the chart defaults and the templates fail when both fields are set. +tests: + - it: renders no PDB by default + asserts: + - hasDocuments: + count: 0 + + - it: renders with minAvailable only when just enabled is set + set: + supersetNode.podDisruptionBudget.enabled: true + supersetWorker.podDisruptionBudget.enabled: true + supersetCeleryBeat.podDisruptionBudget.enabled: true + supersetCeleryFlower.podDisruptionBudget.enabled: true + supersetWebsockets.podDisruptionBudget.enabled: true + supersetMcp.podDisruptionBudget.enabled: true + asserts: + - hasDocuments: Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Wrong expected document count</b></div> <div id="fix"> The assertion `hasDocuments: count: 1` is incorrect. The `templates:` block (lines 18-24) lists 6 PDB templates, and the test at lines 37-42 enables all 6 components — this should produce 6 documents, not 1. This would cause the test to fail at runtime when run against the actual chart. </div> </div> <small><i>Code Review Run #3c0be3</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
