DanielSwift1992 opened a new pull request, #43143:
URL: https://github.com/apache/superset/pull/43143
### SUMMARY
Four of these references became stale when their directories were moved. The
lines themselves were left unchanged while the paths they referenced
disappeared from the tree. CODEOWNERS line 27 points to a path that has never
existed in the tracked tree.
Five one-line edits resolve the stale references: two in CODEOWNERS and
three elsewhere.
1. Update CODEOWNERS line 22 to: `/docs/developer_docs/extensions/`
2. Remove CODEOWNERS line 27. Line 23 already matches the real path.
3. Outside CODEOWNERS, update one line in each of the following:
- the Select stories path in `component-style-guidelines.md:201`
- the output path in `AGENTS.md:170`
- the source link in `CONTRIBUTING.md:38`
### TESTING INSTRUCTIONS
# the two stale lines
sed -n '22p;27p' .github/CODEOWNERS
# tracked files under both referenced paths, 0 before this PR
git ls-files -- 'docs/developer_portal/'
'superset-frontend/src/packages/superset-core/' | wc -l
### ADDITIONAL INFORMATION
While the three component rules matched their directories, 114 commits
recorded changes under them. Since the move, 58 commits changed those
directories over 419 days without a matching CODEOWNERS rule (the rules
themselves were removed in #43079). The docs owners authored 15 of the 20
commits under docs/developer_docs/extensions themselves.
I found this mismatch in your repo while analyzing public data with my tool:
https://github.com/DanielSwift1992/gate. If you need more details, happy to
share.
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
