sadpandajoe opened a new pull request, #43147:
URL: https://github.com/apache/superset/pull/43147
### SUMMARY
In SQL Lab's Saved Queries list, opening a saved query — via the "Edit query"
(pencil) row action, or via the "Open in SQL Lab" button in the Query preview
modal — also copied a permalink to the clipboard and showed a "Link Copied!"
toast, silently overwriting whatever the user had copied. Both actions share
the `openInSqlLab` handler, which unconditionally ran the
clipboard-copy/toast
side effect in addition to navigating. This removes that side effect so
`openInSqlLab` only navigates; the separate "Copy query URL" action keeps its
own, unchanged copy-to-clipboard behavior.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: clicking the pencil "Edit query" icon (or "Open in SQL Lab" in the
preview modal) opened the query in SQL Lab but also showed a "Link Copied!"
toast and overwrote the clipboard with a permalink.
After: both actions only navigate to SQL Lab — no toast, no clipboard change.
The "Copy query URL" action is unaffected and still copies a permalink with
its own toast.
(Video evidence to follow.)
### TESTING INSTRUCTIONS
1. Go to SQL Lab > Saved Queries.
2. Click the "Edit query" (pencil) icon on any saved query. It opens in SQL
Lab; no "Link Copied!" toast appears and the clipboard is untouched.
3. Alternatively, click the "Query preview" (binocular) icon, then "Open in
SQL Lab" in the modal. Same result.
4. Click the "Copy query URL" (copy) icon on a saved query. This should still
show "Link Copied!" and put a permalink on the clipboard, unchanged.
5. `npx jest src/pages/SavedQueryList/SavedQueryList.test.tsx` — all pass,
including new regression tests for the two navigation entry points and the
unchanged copy action.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
