I3eka commented on code in PR #43130:
URL: https://github.com/apache/superset/pull/43130#discussion_r3781391746
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -952,17 +952,31 @@ class FilterConfig(UnknownFieldCheckMixin):
"NOT LIKE",
"IN",
"NOT IN",
+ "IS NULL",
+ "IS NOT NULL",
] = Field(
...,
- description="LIKE/ILIKE use % wildcards. IN/NOT IN take a list.",
+ description=(
+ "LIKE/ILIKE use % wildcards. IN/NOT IN take a list. "
+ "IS NULL/IS NOT NULL omit value."
+ ),
validation_alias=AliasChoices("op", "operator", "opr"),
)
- value: str | int | float | bool | list[str | int | float | bool] = Field(
- ...,
- description="For IN/NOT IN, provide a list.",
+ value: str | int | float | bool | list[str | int | float | bool] | None =
Field(
+ None,
+ description="For IN/NOT IN, provide a list. Omit for null operators.",
validation_alias=AliasChoices("value", "val"),
)
+ @model_validator(mode="after")
+ def validate_value(self) -> "FilterConfig":
+ """Null checks have no comparator; every other operator requires
one."""
+ if self.op in {"IS NULL", "IS NOT NULL"}:
+ self.value = None
Review Comment:
Fixed in b451b6a906. Null operators now reject every non-null value, with a
regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
