rusackas opened a new pull request, #43152:
URL: https://github.com/apache/superset/pull/43152
## SUMMARY
#41714 removed the legacy nvd3 chart pipeline and documented that saved
nvd3 Bubble charts auto-migrate to the ECharts Bubble Chart (`bubble_v2`).
That auto-migration runs against existing rows in an already-populated
metadata database (`superset/migrations/shared/migrate_viz/processors.py`,
`MigrateBubbleChart`), not against the example YAML fixtures loaded fresh
by `superset load-examples` -- so `Life Expectancy VS Rural %` (on the
"World Bank's Data" example dashboard) was left with `viz_type: bubble`,
which has had zero registered plugin since #41714 landed. Every fresh
install running `load-examples` gets a broken chart there.
This migrates the chart's params to `bubble_v2`'s shape: adhoc-metric
`x`/`y`/`size` objects instead of the legacy `sum__<column>` shorthand
strings, dropping legacy-only fields (`compare_lag`, `compare_suffix`,
`country_fieldtype`, `since`/`until`, etc.), matching the working
`bubble_v2` example already in `featured_charts/charts/Bubble.yaml`.
I also audited all 103 example chart YAMLs under `superset/examples/`
for any other `viz_type` without a currently-registered plugin (checked
against the full `VizType` enum plus deck.gl layer types) -- this was
the only one.
### TESTING INSTRUCTIONS
1. `superset load-examples` on this branch.
2. Open the "World Bank's Data" dashboard and confirm "Life Expectancy VS
Rural %" renders as a bubble chart instead of erroring.
Also verified the new params validate against `ImportV1ChartSchema` and
import cleanly through a full `superset db upgrade` + fresh metadata DB.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
