I3eka commented on PR #43135: URL: https://github.com/apache/superset/pull/43135#issuecomment-5294990168
@bsovran @sadpandajoe — update after retesting: I reverted the experimental final-round tool suppression. This draft now leaves the model free to request tools on every allowed max_turns round trip. Its net change is only the terminal classification when the model never chooses to stop: incomplete/error instead of a successful generic fallback. #42805 currently documents that exhaustion answers with what it has, so I am keeping this draft and not requesting formal review yet. Could you confirm which terminal contract is intended? Focused runtime tests pass (33), and the current required unit and pre-commit checks are green. The remaining red CI jobs all stop before tests on the inherited two-Alembic-head state (2d6ad72e4af6 and a1c4f7e29b31), not on this two-file diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
