bito-code-review[bot] commented on PR #43168:
URL: https://github.com/apache/superset/pull/43168#issuecomment-5294998845
<!-- Bito Reply -->
The flagged issue is correct. Running `npm ci` inside a container that
bind-mounts the host's `node_modules` directory will delete and recreate the
directory, which can lead to permission issues (root ownership) and binary
incompatibility with the host OS. To resolve this, you should mount a separate
volume for `node_modules` in your Docker Compose configuration to isolate the
container's dependencies from the host's filesystem.
To implement this, update your `docker-compose.yml` to include a volume
mapping for the frontend dependencies:
```yaml
services:
superset-app:
volumes:
- ./superset-frontend:/app/superset-frontend
- /app/superset-frontend/node_modules
```
This ensures that `npm ci` operates within an isolated volume rather than
modifying the host's directory. Regarding other comments on this PR, the
`pr_comments.csv` file is currently empty, so there are no additional comments
to address.
**docker-compose.yml**
```
services:
superset-app:
volumes:
- ./superset-frontend:/app/superset-frontend
- /app/superset-frontend/node_modules
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
