bito-code-review[bot] commented on code in PR #43129:
URL: https://github.com/apache/superset/pull/43129#discussion_r3785316866
##########
tests/unit_tests/mcp_service/dataset/tool/test_dataset_tools.py:
##########
@@ -2078,6 +2078,37 @@ async def
test_create_virtual_dataset_create_failed(mcp_server: object) -> None:
assert "Failed to create dataset" in data["error"]
[email protected]
+async def test_create_virtual_dataset_sql_error_is_actionable(
+ mcp_server: object,
+) -> None:
+ """Warehouse SQL errors are recoverable tool results, not adapter
crashes."""
+ from superset.exceptions import SupersetGenericDBErrorException
+
+ mock_command = MagicMock()
+ mock_command.run.side_effect = SupersetGenericDBErrorException(
+ "Invalid column name 'missing_value'"
+ )
+
+ with patch(
+ "superset.commands.dataset.create.CreateDatasetCommand",
+ return_value=mock_command,
+ ):
+ async with Client(mcp_server) as client:
+ request = CreateVirtualDatasetRequest(
+ database_id=1,
+ sql="SELECT missing_value FROM sample_events",
+ dataset_name="Test",
+ )
+ result = await client.call_tool(
+ "create_virtual_dataset", {"request": request.model_dump()}
+ )
+ data = json.loads(result.content[0].text)
+
+ assert data["id"] is None
+ assert "Invalid column name" in data["error"]
Review Comment:
<!-- Bito Reply -->
The updated test assertions are appropriate for the diagnostic path. By
asserting that `id` is `None`, `columns` is empty, and `error` is present,
while specifically checking for the presence of the "Invalid column name"
diagnostic, the test correctly validates that the
`SupersetGenericDBErrorException` is handled as an actionable tool result
without exposing raw database driver details to the MCP caller. This approach
balances the need for robust error handling verification with the security
requirement to sanitize diagnostic output.
**tests/unit_tests/mcp_service/dataset/tool/test_dataset_tools.py**
```
assert data["id"] is None
assert "Invalid column name" in data["error"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
