aminghadersohi opened a new issue, #43174: URL: https://github.com/apache/superset/issues/43174
### Summary Follow up on #42822 by applying the shared MCP Jinja form-data context helper to sibling programmatic query paths that compile, preview, or execute `ChartDataCommand`. The review on #42822 identified that a chart can resolve request-dependent Jinja inputs during `get_chart_data` while sibling tools such as `get_chart_sql` may still render fallback values (for example, `No filter`). This can make displayed/previewed SQL diverge from executed SQL. ### Candidate paths Audit and, where applicable, cover: - `get_chart_data._query_from_form_data` (`form_data_key` branch) - `get_chart_sql` - `get_chart_preview` - chart `preview_utils` - chart `compile` - `semantic_layer/get_table` - any other programmatic `ChartDataCommand` construction paths ### Acceptance criteria - Equivalent query contexts expose the same Jinja inputs across execution, SQL generation, compilation, and preview paths. - `filters`, `time_range`, `url_params`, and implicit dataset lookup behave consistently where supported. - Tests use real `QueryObject`/`QueryContext` shapes rather than mocked serializer output. - Authorization and guest-scope behavior remain unchanged. - Each adopted path has focused regression coverage. ### Context Raised during review of #42822: https://github.com/apache/superset/pull/42822#discussion_r3784861047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
