aminghadersohi commented on PR #42822: URL: https://github.com/apache/superset/pull/42822#issuecomment-5296438004
Final review-comment audit complete: - Both blocking human-review findings are fixed and the reviewer has re-verified the behavior with real objects and approved the PR. - The earlier automated suggestions are also covered: imports are module-level, the duplicate async-query setter now uses the shared helper, and the helper has dedicated unit coverage. - The non-blocking sibling-path follow-up promised in review is tracked in #43174: https://github.com/apache/superset/issues/43174 Latest update: 8c10f89f5e. Pre-commit passes on all changed files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
