NoiceHax commented on PR #43151:
URL: https://github.com/apache/superset/pull/43151#issuecomment-5296899942
Pushed a follow-up for the review bots' points on the integration test.
The old mock replaced security_manager.can_access for the whole request, so
every other permission check got a stubbed answer too, and the lambda would
have blown up on a keyword-argument call. It now forces only ("can_view_query",
"Dashboard") and delegates the rest to the real security manager. Docstring
typo fixed as well.
I left the @pytest.mark.skip on TestGetChartDataApi alone. It is skipped on
master for an unrelated DuckDB example-data reason, so unskipping it here is
out of scope for this fix. The behaviour is covered by the unit tests in
tests/unit_tests/charts/test_chart_data_api.py, which do run in CI.
Verified with ruff 0.9.7 (check and format, both clean). I could not run the
Python suite locally, no superset env on this machine, so I am relying on CI
for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
