bikash-barnwal commented on issue #42433:
URL: https://github.com/apache/superset/issues/42433#issuecomment-5297986313
This looks fixed on `master` already — by #40729 (`c87fdfc18f`, 2026-06-26),
which landed *after* the `6.1.0` image you tested.
The embedded entry point now does run the preamble, eagerly at module load:
```ts
// superset-frontend/src/embedded/index.tsx
function loadPlugins() {
return initPreamble() // <- the i18n bootstrap
.catch(...)
.then(async () => { /* setupPlugins, setupCodeOverrides */ });
}
function schedulePlugins() {
const promise = loadPlugins();
promise.catch(() => {});
return promise;
}
// Kick off plugin setup eagerly at module load so it overlaps the handshake.
let pluginsReady = schedulePlugins();
```
and `initPreamble` reaches the language pack with no logged-in-user gate
(`preamble.ts:76-105`) — it prefers a pack already on hand
(`common.language_pack` from `COMMON_BOOTSTRAP_OVERRIDES_FUNC`, or the
`window.__SUPERSET_LANGUAGE_PACK__` global set by the versioned script tag) and
only falls back to `fetch('/language_pack/<locale>/')` when neither is present.
That last part is worth knowing for reproduction: if the pack arrives via
the bootstrap payload or the script-tag global, **you will still see no
`/superset/language_pack/` request in the access log** even though translations
are working. So the absence of that request is no longer sufficient evidence on
current master — the thing to check is whether the strings actually render
translated.
Your diagnosis of 6.1.0 was accurate, and the deferral in #40729 is also
what fixes the related trap where module-level `const X = t('...')` in plugin
control panels got cached in English before the pack loaded.
Could you confirm against `master` or a nightly image? If the strings are
still English there, it is a different defect from the one described here and
it would help to say which strings and whether `common.locale` in the
`/embedded/<uuid>` bootstrap payload is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
