bikash-barnwal opened a new pull request, #43193: URL: https://github.com/apache/superset/pull/43193
### SUMMARY Setting **X Axis Label Interval** to *All* did nothing — charts kept showing every nth label. The control is a `SelectControl` whose choices are `['auto', 'Auto']` and `['0', 'All']`, so *All* is stored as the **string** `'0'`. ECharts' `axisLabel.interval` only understands `'auto'` or a number; a string is not a valid value, so it was ignored and the axis fell back to its default label thinning. There is a second half to it. Even with a numeric `0`, `hideOverlap` is enabled for non-rotated axes: ```ts hideOverlap: !(xAxisType === AxisType.Time && xAxisLabelRotation !== 0), ``` and `hideOverlap` drops labels that collide — exactly the labels *All* exists to show. So fixing only the type coercion would still not honor the setting. This adds a small `getAxisLabelInterval` helper that normalizes the control value to what ECharts accepts (falling back to `'auto'` for anything unparseable, rather than handing the axis a bad value) and reports whether the user asked for every label. Timeseries and MixedTimeseries use it to set `interval` and to disable `hideOverlap` in that one case. **Left alone deliberately:** Bubble passes the same control value to `xAxis.interval` rather than `axisLabel.interval` — a different option, measured in value units rather than label counts. Changing it would alter tick spacing, not label density, so it is out of scope here and worth a separate look. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: with *All* selected, an Area/Time-series chart still renders roughly every 4th label. After: every category label renders. ### TESTING INSTRUCTIONS ```bash cd superset-frontend npm run test -- plugins/plugin-chart-echarts/test ``` **775 tests across 69 suites pass.** New cases: a unit test for the helper (string `'0'`, `'auto'`, `undefined`, `null`, a nonsense value, and an explicit `2`), and a Timeseries test asserting `interval === 0` with `hideOverlap === false`. Two of the three fail on unpatched source; the third pins the `'auto'` default so the new branch cannot regress it. Manually: any Time-series or Area chart → Customize → **X Axis Label Interval** → *All*, and confirm every label renders. ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes #36325 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
