bikash-barnwal commented on PR #43185:
URL: https://github.com/apache/superset/pull/43185#issuecomment-5298801965
The failing `playwright-tests (chromium)` job here is unrelated to this
change — filed as #43200.
It is `recently-archived.spec.ts:192` ("shows an empty message and no rows
when the search matches nothing"), which touches no export code. It has now
failed on three separate runs across this PR and #43188 (both export-related
but in completely different code paths), while passing on #43184, #43189,
#43179, #43186 and #43187 from the same base.
The received counts in the failure — 22 rows on the first attempt, 23 on the
retry — are the unfiltered list, so the search never applied rather than
matching too much; the varying count comes from however many archived items
other specs in the shard happened to create. Diagnosis and suggested fix are in
#43200.
This PR's own checks are green: `pytest
tests/unit_tests/utils/send_export_zip_tests.py` (4) and `pytest
tests/unit_tests/ -k export` (180 passed, 1 skipped).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
