bito-code-review[bot] commented on code in PR #43215:
URL: https://github.com/apache/superset/pull/43215#discussion_r3788991510
##########
superset-frontend/src/views/routes.tsx:
##########
@@ -32,161 +28,161 @@ import { RoutePaths } from './routePaths';
// not lazy loaded since this is the home page.
import Home from 'src/pages/Home';
-const ChartCreation = lazy(
+const ChartCreation = lazyWithRetry(
() =>
import(/* webpackChunkName: "ChartCreation" */ 'src/pages/ChartCreation'),
);
-const AnnotationLayerList = lazy(
+const AnnotationLayerList = lazyWithRetry(
() =>
import(
/* webpackChunkName: "AnnotationLayerList" */
'src/pages/AnnotationLayerList'
),
);
-const AlertReportList = lazy(
+const AlertReportList = lazyWithRetry(
() =>
import(
/* webpackChunkName: "AlertReportList" */ 'src/pages/AlertReportList'
),
);
-const AnnotationList = lazy(
+const AnnotationList = lazyWithRetry(
() =>
import(/* webpackChunkName: "AnnotationList" */
'src/pages/AnnotationList'),
);
-const ChartList = lazy(
+const ChartList = lazyWithRetry(
() => import(/* webpackChunkName: "ChartList" */ 'src/pages/ChartList'),
);
-const ArchivedList = lazy(
+const ArchivedList = lazyWithRetry(
() => import(/* webpackChunkName: "ArchivedList" */
'src/pages/ArchivedList'),
);
-const CssTemplateList = lazy(
+const CssTemplateList = lazyWithRetry(
() =>
import(
/* webpackChunkName: "CssTemplateList" */ 'src/pages/CssTemplateList'
),
);
-const ThemeList = lazy(
+const ThemeList = lazyWithRetry(
() => import(/* webpackChunkName: "ThemeList" */ 'src/pages/ThemeList'),
);
-const DashboardList = lazy(
+const DashboardList = lazyWithRetry(
() =>
import(/* webpackChunkName: "DashboardList" */ 'src/pages/DashboardList'),
);
-const Dashboard = lazy(
+const Dashboard = lazyWithRetry(
() => import(/* webpackChunkName: "Dashboard" */ 'src/pages/Dashboard'),
);
-const DatabaseList = lazy(
+const DatabaseList = lazyWithRetry(
() => import(/* webpackChunkName: "DatabaseList" */
'src/pages/DatabaseList'),
);
-const DatasetList = lazy(
+const DatasetList = lazyWithRetry(
() => import(/* webpackChunkName: "DatasetList" */ 'src/pages/DatasetList'),
);
-const DatasetCreation = lazy(
+const DatasetCreation = lazyWithRetry(
() =>
import(
/* webpackChunkName: "DatasetCreation" */ 'src/pages/DatasetCreation'
),
);
-const ExecutionLogList = lazy(
+const ExecutionLogList = lazyWithRetry(
() =>
import(
/* webpackChunkName: "ExecutionLogList" */ 'src/pages/ExecutionLogList'
),
);
-const Chart = lazy(
+const Chart = lazyWithRetry(
() => import(/* webpackChunkName: "Chart" */ 'src/pages/Chart'),
);
-const QueryHistoryList = lazy(
+const QueryHistoryList = lazyWithRetry(
() =>
import(
/* webpackChunkName: "QueryHistoryList" */ 'src/pages/QueryHistoryList'
),
);
-const SavedQueryList = lazy(
+const SavedQueryList = lazyWithRetry(
() =>
import(/* webpackChunkName: "SavedQueryList" */
'src/pages/SavedQueryList'),
);
-const SqlLab = lazy(
+const SqlLab = lazyWithRetry(
() => import(/* webpackChunkName: "SqlLab" */ 'src/pages/SqlLab'),
);
-const AllEntities = lazy(
+const AllEntities = lazyWithRetry(
() => import(/* webpackChunkName: "AllEntities" */ 'src/pages/AllEntities'),
);
-const Tags = lazy(
+const Tags = lazyWithRetry(
() => import(/* webpackChunkName: "Tags" */ 'src/pages/Tags'),
);
-const Extensions = lazy(
+const Extensions = lazyWithRetry(
() => import(/* webpackChunkName: "Tags" */ 'src/extensions/ExtensionsList'),
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Duplicate webpack chunk name</b></div>
<div id="fix">
The `Extensions` route at line 134 uses `webpackChunkName: "Tags"`, which is
already assigned to the `Tags` page at line 130. These are separate modules
(`src/pages/Tags` vs `src/extensions/ExtensionsList`) that should not share a
chunk name. Duplicate chunk names cause webpack to group unrelated modules
together, leading to unnecessary cache invalidation when only one module
changes.
</div>
</div>
<small><i>Code Review Run #dc4682</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
