abolfazlmadanii commented on PR #36111: URL: https://github.com/apache/superset/pull/36111#issuecomment-5302519658
Hi @rusackas, @msyavuz, @sadpandajoe, and @michael-s-molina, Thank you again for the architectural feedback. We found the existing `filter.dateFilterControl` extension point introduced in #33829 and confirmed that it is still present in the current `master`. We are planning to replace the previous core-specific implementation with a standalone multi-calendar `.supx` extension. The extension would: - use Unicode calendar identifiers; - support Persian and other commonly used calendar systems; - persist canonical Gregorian/ISO time-range values; - keep all calendar-specific dependencies outside Superset core; - preserve Superset's inclusive-start/exclusive-end time-range contract. Before implementation, we would like to confirm one architectural point: **Is the legacy `filter.dateFilterControl` extension point currently accessible from the new `.supx` extension loader?** If it is not, would maintainers be open to a small, focused core PR that exposes this existing extension point through `@apache-superset/core`, without introducing any calendar-specific code or dependencies into Superset core? We would appreciate confirmation on this direction before starting the rewrite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
