bito-code-review[bot] commented on PR #43223: URL: https://github.com/apache/superset/pull/43223#issuecomment-5302633643
<!-- Bito Reply --> The reviewer's suggestion is valid. The current implementation only prevents unsupported filters from appearing in the *available* parent options, but it does not actively remove existing dependency edges if a filter's capability changes while the modal is open. To resolve this, you should update the filter operations to explicitly prune dependencies when a filter's `supportsCascadeDependencies` status changes. I have analyzed the PR and confirmed that the issue is correct. Would you like me to fetch all other comments on this PR to validate them and implement a minimal fix for all of them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
