SEPURI-SAI-KRISHNA commented on PR #43222: URL: https://github.com/apache/superset/pull/43222#issuecomment-5303030423
See the inline thread on `query_context_processor.py` for the detail, the short version is that `QueryObject.cache_key()` already pops `contribution_totals` before hashing, and for the QueryContext key the totals are derived from query definitions that are themselves in the key, so they add no entropy that could collapse two distinct keys. Relative to `master`, where Decimal totals are absent from the key entirely, this change makes the key strictly more sensitive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
