aminghadersohi commented on PR #43260: URL: https://github.com/apache/superset/pull/43260#issuecomment-5318385413
> @aminghadersohi what is the purpose of this revert? Staying on SQLA 1.x is not sustainable, hence we should fix forward with 2.x rather than reverting to a version that's no longer actively maintained. Do note that we're still in the breaking window, so breakage due to major changes is expected. > > CC: @rusackas Hi @villebro we had some discussions about revert, vs a dual compat pr, vs fix forward so i put up the prs quick. but the vote seems to be 'fix forward' so switching this to draft in case something blocks that plan, but will close this later (probably sooner). thanks for the comment/vote. appreciated as always. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
