bito-code-review[bot] commented on PR #43271:
URL: https://github.com/apache/superset/pull/43271#issuecomment-5320807483
<!-- Bito Reply -->
The flagged issue is correct. Using `trigger="hover"` on a `Popover` makes
the chart description inaccessible on touch-based mobile devices. To resolve
this, you should change the trigger to `click` or support both `hover` and
`click` (if the component library allows) to ensure mobile users can open the
description.
Here is the suggested fix for
`superset-frontend/src/dashboard/components/SliceHeader/index.tsx`:
```tsx
{slice.description && !isExpanded && (
<Popover
trigger={['hover', 'click']}
content={<SliceInfo slice={slice} />}
placement="leftBottom"
>
<Icons.InfoCircleOutlined
iconSize="m"
aria-label={t('Chart description')}
data-test="chart-description-info-icon"
/>
</Popover>
)}
```
I have checked the PR comments, and there are no other comments to address
at this time. Would you like me to perform any further checks or implement
additional changes?
**superset-frontend/src/dashboard/components/SliceHeader/index.tsx**
```
<Popover
trigger={['hover', 'click']}
content={<SliceInfo slice={slice} />}
placement="leftBottom"
>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
