endimonan commented on PR #43280: URL: https://github.com/apache/superset/pull/43280#issuecomment-5325327019
I think the codecov number here is a bit misleading. From what I can tell, the unit test job ends up overwriting its own coverage file before uploading (the targeted 100% runs at the end replace the main run's .coverage), so the patch % only reflects the integration suites. The flagged lines should all be covered by the unit tests in this PR. Other backend PRs seem to show the same pattern, like #43252. Happy to be corrected if I got that wrong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
