aminghadersohi commented on PR #43191:
URL: https://github.com/apache/superset/pull/43191#issuecomment-5332555131
Thanks for the thorough review @gabotorresruiz! Both nits addressed in
4f90357:
- The 400 branch now fires on any truthy `message` (object or plain string),
so `PUT /api/v1/security/users/<pk>` returning `{"message": "User must have at
least one role or group!"}` surfaces the server text instead of the generic
toast.
- `errorData.error?.includes('duplicate key value')` guards the 422 path so
a JSON body with neither `message` nor `errors` can no longer throw before
`addDangerToast`.
Two tests added for those shapes; the users suite passes (5/5). Left
`GroupListModal.tsx` alone for a follow-up as suggested — happy to file it
separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
